snuyanzin commented on code in PR #106:
URL:
https://github.com/apache/flink-connector-kafka/pull/106#discussion_r1650411180
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java:
##########
@@ -47,33 +48,34 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** Tests for {@link KafkaRecordSerializationSchemaBuilder}. */
-public class KafkaRecordSerializationSchemaBuilderTest extends TestLogger {
+@ExtendWith({TestLoggerExtension.class})
Review Comment:
IIRC we don't need to put each time this `ExtendsWith` for almost every test
instead just put it once in services (common practice in different flink
modules) like e.g. here
https://github.com/apache/flink/blob/e3b123d7d1e48e7adbb04fb3470d02bb76f5ff73/flink-formats/flink-avro-confluent-registry/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension#L16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
