yuxiqian commented on code in PR #3432:
URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650541336
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java:
##########
Review Comment:
Well my scratch idea is creating a dummy `BinaryLogClient` that actually
does nothing:
```java
private static class DummyBinaryLogClient extends BinaryLogClient {
public DummyBinaryLogClient() {
super(null, null);
}
@Override
public void connect() throws IllegalStateException {
// Do nothing
}
@Override
public void disconnect() {
// Do nothing
}
@Override
public void registerEventListener(EventListener eventListener) {
// Do nothing
}
@Override
public void unregisterEventListener(Class<? extends EventListener>
listenerClass) {
// Do nothing
}
}
```
By passing this binlog client instance to `DebeziumUtils#searchBinlogName`,
it is ensured that no BinlogTimestamps could be found and added to the blocking
queue, so we can verify if the timeout mechanism works as expected.
Also looking forward to @ruanhang1993's thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
