whhe commented on PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#issuecomment-2191654815
Thanks for the update, now we know the blocking is caused by two reasons: 1. We did not deal with empty queue. 2. The BinaryLogClient is missing LifecycleListener, or more specifically, missing throwing exception in `onCommunicationFailure`. To fix it, I prefer to add a anonymous LifecycleListener which throw the exception directly, and for empty queue, just return null and remove the current binlog file from the list. This fix could be straightforward and easy to test (using binlog file that only contains rotate events and using same server id). What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
