[ 
https://issues.apache.org/jira/browse/FLINK-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707691#comment-15707691
 ] 

ASF GitHub Bot commented on FLINK-5209:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2902#discussion_r90174505
  
    --- Diff: 
flink-runtime-web/web-dashboard/app/partials/taskmanager/taskmanager.metrics.jade
 ---
    @@ -75,18 +75,18 @@ div(ng-if="metrics.id")
         tbody
           tr
             td Direct
    -        td {{ metrics.metrics.directCount }}
    -        td {{ metrics.metrics.directUsed }}
    -        td {{ metrics.metrics.directTotal }}
    +        td {{ metrics.metrics.directCount | humanizeBytes }}
    +        td {{ metrics.metrics.directUsed | humanizeBytes }}
    +        td {{ metrics.metrics.directMax | humanizeBytes }}
           tr
             td Mapped
    -        td {{ metrics.metrics.mappedCount }}
    -        td {{ metrics.metrics.mappedUsed }}
    -        td {{ metrics.metrics.mappedMax }}
    +        td {{ metrics.metrics.mappedCount | humanizeBytes }}
    --- End diff --
    
    The unit for none of these metrics is bytes


> Fix TaskManager metrics
> -----------------------
>
>                 Key: FLINK-5209
>                 URL: https://issues.apache.org/jira/browse/FLINK-5209
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.2.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.2.0
>
>
> Properly propagate the network and non-JVM memory metrics to the web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to