[
https://issues.apache.org/jira/browse/FLINK-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707706#comment-15707706
]
ASF GitHub Bot commented on FLINK-5209:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2902#discussion_r90175096
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -124,13 +124,21 @@ public String handleJsonRequest(Map<String, String>
pathParams, Map<String, Stri
gen.writeNumberField("totalUsed", heapUsed + nonHeapUsed);
gen.writeNumberField("totalMax", heapTotal + nonHeapTotal);
-
gen.writeStringField("directCount",
metrics.getMetric("Status.JVM.Memory.Direct.Count", "0"));
-
gen.writeStringField("directUsed",
metrics.getMetric("Status.JVM.Memory.Direct.MemoryUsed", "0"));
-
gen.writeStringField("directMax",
metrics.getMetric("Status.JVM.Memory.Direct.TotalCapacity", "0"));
+ long directCount =
Long.valueOf(metrics.getMetric("Status.JVM.Memory.direct.Count", "0"));
+ long directUsed =
Long.valueOf(metrics.getMetric("Status.JVM.Memory.direct.MemoryUsed", "0"));
+ long directMax =
Long.valueOf(metrics.getMetric("Status.JVM.Memory.direct.TotalCapacity", "0"));
-
gen.writeStringField("mappedCount",
metrics.getMetric("Status.JVM.Memory.Mapped.Count", "0"));
-
gen.writeStringField("mappedUsed",
metrics.getMetric("Status.JVM.Memory.Mapped.MemoryUsed", "0"));
-
gen.writeStringField("mappedMax",
metrics.getMetric("Status.JVM.Memory.Mapped.TotalCapacity", "0"));
+
gen.writeNumberField("directCount", directCount);
+
gen.writeNumberField("directUsed", directUsed);
+
gen.writeNumberField("directMax", directMax);
+
+ long mappedCount =
Long.valueOf(metrics.getMetric("Status.JVM.Memory.mapped.Count", "0"));
+ long mappedUsed =
Long.valueOf(metrics.getMetric("Status.JVM.Memory.mapped.MemoryUsed", "0"));
+ long mappedMax =
Long.valueOf(metrics.getMetric("Status.JVM.Memory.mapped.TotalCapacity", "0"));
+
+
gen.writeNumberField("mappedCount", mappedCount);
+
gen.writeNumberField("mappedUsed", mappedUsed);
+
gen.writeNumberField("mappedMax", mappedMax);
gen.writeStringField("memorySegmentsAvailable",
metrics.getMetric("Status.Network.AvailableMemorySegments", "0"));
--- End diff --
If you change the above to write longs these can be changed as well, along
with with the GC metrics.
> Fix TaskManager metrics
> -----------------------
>
> Key: FLINK-5209
> URL: https://issues.apache.org/jira/browse/FLINK-5209
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
> Affects Versions: 1.2.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Fix For: 1.2.0
>
>
> Properly propagate the network and non-JVM memory metrics to the web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
