yuxiqian commented on code in PR #3461:
URL: https://github.com/apache/flink-cdc/pull/3461#discussion_r1671422254
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/json/debezium/DebeziumJsonSerializationSchema.java:
##########
@@ -185,14 +190,21 @@ public byte[] serialize(Event event) {
}
}
+ /**
+ * Refer to <a
+ *
href="https://debezium.io/documentation/reference/1.9/connectors/mysql.html";>...</a>.
Review Comment:
Hyperlink text
[`...`](https://debezium.io/documentation/reference/1.9/connectors/mysql.html)
could be replaced with some meaningful words, like:
```suggestion
* Refer to <a
*
href="https://debezium.io/documentation/reference/1.9/connectors/mysql.html";>Debezium
docs</a> for more details.
```
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/json/canal/CanalJsonSerializationSchema.java:
##########
@@ -200,14 +211,19 @@ public byte[] serialize(Event event) {
}
}
+ /**
+ * Refer to <a
+ *
href="https://github.com/alibaba/canal/blob/9373429015c0f25318b703833a1d7913676f2aa3/protocol/src/main/java/com/alibaba/otter/canal/protocol/FlatMessage.java#L74";>...</a>.
+ */
Review Comment:
Since Canal has no official protocol docs, will it be better if we change
the link to [Canal | Apache
Flink](https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/formats/canal/#available-metadata)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
