Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2910#discussion_r90235653
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphStore.java
---
@@ -275,6 +242,25 @@ public void removeJobGraph(JobID jobId) throws
Exception {
}
}
+ @Override
+ public Collection<JobID> getJobIds() throws Exception {
+ Collection<String> paths;
+
+ try {
+ paths = jobGraphsInZooKeeper.getAllPaths();
+ } catch (Exception e) {
+ throw new Exception("Failed to retrieve entry paths
from ZooKeeperStateHandleStore.", e);
+ }
+
+ List<JobID> jobIds = new ArrayList<>(paths.size());
+
+ for (String path : paths) {
+ jobIds.add(jobIdfromPath(path));
--- End diff --
If we have a malformatted sub node, this will skip recovery of all jobs
again, right? Wondering if we should wrap this line in a `try-catch`. It's
quite unlikely though as someone would need to put the node there manually ;)
Feel free to not address this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
