XComp commented on code in PR #25027:
URL: https://github.com/apache/flink/pull/25027#discussion_r1673562535
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java:
##########
@@ -85,7 +85,16 @@ public Collection<JobManagerRunner> getJobManagerRunners() {
@Override
public CompletableFuture<Void> localCleanupAsync(JobID jobId, Executor
unusedExecutor) {
if (isRegistered(jobId)) {
- return unregister(jobId).closeAsync();
+ CompletableFuture<Void> resultFuture =
this.jobManagerRunners.get(jobId).closeAsync();
+
+ resultFuture.whenComplete(
+ (result, throwable) -> {
+ if (throwable == null) {
+ unregister(jobId);
Review Comment:
That question is answered by the [method's
JavaDoc](https://github.com/apache/flink/blob/6cdb97c42b01a2eb3306784d240e16d202313ba2/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableResource.java#L46):
> @param cleanupExecutor The fallback executor for IO-heavy operations.
So no, unfortunately, it's not the main thread executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
