kumar-mallikarjuna commented on code in PR #25027:
URL: https://github.com/apache/flink/pull/25027#discussion_r1683288457
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java:
##########
@@ -97,6 +106,14 @@ public JobManagerRunner unregister(JobID jobId) {
return this.jobManagerRunners.remove(jobId);
}
+ public void setMainThreadExecutor(ComponentMainThreadExecutor executor) {
+ mainThreadExecutor = executor;
+ }
+
+ public ComponentMainThreadExecutor getMainThreadExecutor() {
+ return mainThreadExecutor;
+ }
+
Review Comment:
You mean combing Factory and Builder patterns for
`DispatcherResourceCleanerFactory`? How about passing the
`JobManagerRunnerRegistry` along with `ComponentMainThreadExecutor` in the
creator methods there?
```java
public ResourceCleaner createLocalResourceCleaner(
ComponentMainThreadExecutor mainThreadExecutor,
+ JobManagerRunnerRegistry jobManagerRunnerRegistry);
```
```java
public ResourceCleaner createGlobalResourceCleaner(
ComponentMainThreadExecutor mainThreadExecutor,
+ JobManagerRunnerRegistry jobManagerRunnerRegistry);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
