Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2653#discussion_r90036667
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
 ---
    @@ -753,8 +777,9 @@ class CodeGenerator(
         }
       }
     
    -  override def visitCorrelVariable(correlVariable: RexCorrelVariable): 
GeneratedExpression =
    -    throw new CodeGenException("Correlating variables are not supported 
yet.")
    +  override def visitCorrelVariable(correlVariable: RexCorrelVariable): 
GeneratedExpression = {
    --- End diff --
    
    You implemented this method only for table functions right? Is it possible 
that other SQL queries that are actually not supported call this method by 
accident. This would lead to undesired behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to