Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2653#discussion_r90442225
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala
 ---
    @@ -451,6 +452,28 @@ object ExpressionParser extends JavaTokenParsers with 
PackratParsers {
         }
       }
     
    +  lazy val tableFunctionCall: PackratParser[LogicalNode] =
    +    functionIdent ~ "(" ~ repsep(expression, ",") ~ ")" ^^ {
    +    case name ~ _ ~ args ~ _ => 
UnresolvedTableFunctionCall(name.toUpperCase, args)
    --- End diff --
    
    I think it would not hurt if we support `split(c) as (f1, f2)` for all 
expressions. This could also help in cases where we expand the projection like 
`pojo.flatten() as (f1, f2)`. I don't like the idea of a logical parser. It is 
already confusing enough for the user that we have Java API expression strings 
and SQL strings, we don't need another string syntax.
    @fhueske what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to