Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2653#discussion_r90050627
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/SqlFunctionUtils.scala
 ---
    @@ -28,14 +28,14 @@ import org.apache.calcite.util.BuiltInMethod
     import org.apache.flink.api.common.typeinfo.BasicTypeInfo._
     import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, 
SqlTimeTypeInfo, TypeInformation}
     import org.apache.flink.api.java.typeutils.GenericTypeInfo
    -import org.apache.flink.api.table.functions.utils.ScalarSqlFunction
    +import org.apache.flink.api.table.functions.utils.{TableSqlFunction, 
ScalarSqlFunction}
     
     import scala.collection.mutable
     
     /**
    -  * Global hub for user-defined and built-in advanced SQL scalar functions.
    +  * Global hub for user-defined and built-in advanced SQL functions.
       */
    -object ScalarFunctions {
    +object SqlFunctionUtils {
    --- End diff --
    
    We could call this `FunctionGenerator`. IMO it is more than just a util 
class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to