yuxiqian commented on code in PR #2944:
URL: https://github.com/apache/flink-cdc/pull/2944#discussion_r1690696796
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TableChangeInfo.java:
##########
@@ -139,6 +144,10 @@ public TableChangeInfo deserialize(int version, byte[]
serialized) throws IOExce
try (ByteArrayInputStream bais = new
ByteArrayInputStream(serialized);
DataInputStream in = new DataInputStream(bais)) {
TableId tableId = tableIdSerializer.deserialize(new
DataInputViewStreamWrapper(in));
+ if (tableId.equals(magicTableId)) {
+ version = in.readInt();
+ tableId = tableIdSerializer.deserialize(new
DataInputViewStreamWrapper(in));
+ }
Review Comment:
If no `magicTableId` was present, `version` will not be overwritten and
defaults to be latest version (`TableChangeInfo.SERIALIZER.getVersion()`). Is
this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
