yuxiqian commented on PR #2944:
URL: https://github.com/apache/flink-cdc/pull/2944#issuecomment-2249296709
Thanks for @lvyanquan's rapid response! Ran migration tests and it works as
expected.
* `TableChangeInfo#Serializer#magicTableId` should be named in screaming
case `MAGIC_TABLE_ID` as a `static final` constant, or Spotless will complain.
* `MySqlPipelineITCase` needs update to reflect changes in default value:
```
Error: MySqlPipelineITCase.testInitialStartupMode:228
expected: CreateTableEvent{tableId=inventory_kohdit.products,
schema=columns={`id` INT NOT NULL,`name` VARCHAR(255) NOT NULL,`description`
VARCHAR(512),`weight` FLOAT}, primaryKeys=id, options=()}
but was: CreateTableEvent{tableId=inventory_kohdit.products,
schema=columns={`id` INT NOT NULL,`name` VARCHAR(255) NOT NULL
'flink',`description` VARCHAR(512),`weight` FLOAT}, primaryKeys=id, options=()}
...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
