pgaref commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1690790290
########## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeFunction.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.dql; + +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; + +import java.util.Collections; +import java.util.List; + +/** + * DESCRIBE FUNCTION [EXTENDED] [[catalogName.] dataBasesName].sqlIdentifier sql call. Here we add + * Rich in className to follow the convention of {@link org.apache.calcite.sql.SqlDescribeTable}, + * which only had it to distinguish from calcite's original SqlDescribeTable, even though calcite + * does not have SqlDescribeFunction. + */ +public class SqlRichDescribeFunction extends SqlCall { + + public static final SqlSpecialOperator OPERATOR = + new SqlSpecialOperator("DESCRIBE FUNCTION", SqlKind.OTHER); + protected final SqlIdentifier functionNameIdentifier; + private boolean isExtended; + + public SqlRichDescribeFunction( + SqlParserPos pos, SqlIdentifier functionNameIdentifier, boolean isExtended) { + super(pos); + this.functionNameIdentifier = functionNameIdentifier; + this.isExtended = isExtended; + } + + @Override + public SqlOperator getOperator() { + return OPERATOR; + } + + @Override + public List<SqlNode> getOperandList() { + return Collections.singletonList(functionNameIdentifier); + } + + public boolean isExtended() { + return isExtended; + } + + public String[] fullFunctionName() { + return functionNameIdentifier.names.toArray(new String[0]); Review Comment: ```suggestion return functionNameIdentifier.names.toArray(new String[functionNameIdentifier.names.size]); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
