nateab commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1706078687
########## flink-table/flink-sql-client/src/test/resources/sql/function.q: ########## @@ -346,3 +346,69 @@ show user functions; SHOW JARS; Empty set !ok + +# ========================================================================== +# test describe function +# ========================================================================== + +ADD JAR '$VAR_UDF_JAR_PATH'; +[INFO] Execute statement succeeded. +!info + +describe function temp_upperudf; ++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+ +| info name | $VAR_UDF_JAR_PATH_SPACE info value | Review Comment: Yes i totally agree about it making difficult to read, but this the current standard. The variables are defined here https://github.com/apache/flink/blob/master/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java#L148-L168 and this how we handle using the generated temporary jar paths in the tests, while still having correctly formatted tables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
