twalthr commented on code in PR #24317:
URL: https://github.com/apache/flink/pull/24317#discussion_r1698157938
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -3266,6 +3266,64 @@ void testCreateModelAsWithOutput() {
"CREATE MODEL AS SELECT syntax does
not support to specify explicit output columns."));
}
+ @Test
+ void testFromValuesWithoutParens() {
+ sql("select 1 from ^values^('x')")
Review Comment:
maybe add some comment when upgrading calcite
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -3266,6 +3266,64 @@ void testCreateModelAsWithOutput() {
"CREATE MODEL AS SELECT syntax does
not support to specify explicit output columns."));
}
+ @Test
+ void testFromValuesWithoutParens() {
Review Comment:
use proper english here
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CorrelateITCase.scala:
##########
@@ -389,6 +389,25 @@ class CorrelateITCase extends StreamingTestBase {
assertThat(sink.getAppendResults.sorted).isEqualTo(expected.sorted)
}
+ @Test
+ def testL1eftJoinPartialProjectWithEmptyOutput(): Unit = {
Review Comment:
```suggestion
def testLeftJoinPartialProjectWithEmptyOutput(): Unit = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
