snuyanzin commented on code in PR #24317:
URL: https://github.com/apache/flink/pull/24317#discussion_r1698288897
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -3266,6 +3266,64 @@ void testCreateModelAsWithOutput() {
"CREATE MODEL AS SELECT syntax does
not support to specify explicit output columns."));
}
+ @Test
+ void testFromValuesWithoutParens() {
Review Comment:
This is the actual name from Calcite and here we override it in order to
have same tests as in 1.38 to test the actual issue
https://github.com/apache/calcite/blame/0c6a3c1face14cf8136a593ec25a7f13631a09df/testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java#L4359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
