dylanhz commented on code in PR #25122:
URL: https://github.com/apache/flink/pull/25122#discussion_r1699456970


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java:
##########
@@ -964,6 +964,14 @@ private static BinaryStringData 
trimLeftSlow(BinaryStringData str) {
         }
     }
 
+    public static boolean isEmpty(BinaryStringData str) {
+        if (str.javaObject != null) {
+            return str.javaObject.isEmpty();
+        } else {
+            return str.binarySection == null || 
str.binarySection.getSizeInBytes() == 0;

Review Comment:
   Test will be in `BinaryStringDataTest#testIsEmpty`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to