dylanhz commented on code in PR #25122:
URL: https://github.com/apache/flink/pull/25122#discussion_r1703470383
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/StringFunctionsITCase.java:
##########
@@ -25,12 +25,17 @@
import static org.apache.flink.table.api.Expressions.$;
import static org.apache.flink.table.api.Expressions.call;
+import static org.apache.flink.table.api.Expressions.lit;
/** Test String functions correct behaviour. */
class StringFunctionsITCase extends BuiltInFunctionTestBase {
@Override
Stream<TestSetSpec> getTestSetSpecs() {
+ return Stream.of(regexpExtractTestCases(),
translateTestCases()).flatMap(s -> s);
Review Comment:
Maybe we can make this method more generic, because `concat` only works with
two parameters, whereas we may need an arbitrary number of parameters, using
`concat` just for two parameters specially seems unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
