whhe commented on code in PR #109:
URL:
https://github.com/apache/flink-connector-jdbc/pull/109#discussion_r1700044488
##########
flink-connector-jdbc-oceanbase/src/main/java/org/apache/flink/connector/jdbc/oceanbase/database/OceanBaseFactory.java:
##########
@@ -54,6 +55,20 @@ public JdbcCatalog createCatalog(
String username,
String pwd,
String baseUrl) {
- throw new UnsupportedOperationException("Catalog for OceanBase is not
supported yet.");
+ throw new UnsupportedOperationException(
+ "Catalog for OceanBase without 'compatible-mode' is not
supported.");
Review Comment:
'mysql' can be taken as the default value, but the method here should never
be called, so I prefer to keep it throwing an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
