leonardBang commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1705002901
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##########
@@ -359,6 +407,15 @@ private static Java.Rvalue generateTypeConvertMethod(
case "VARCHAR":
case "STRING":
return new Java.MethodInvocation(Location.NOWHERE, null,
"castToString", atoms);
+ case "TIMESTAMP":
+ List<Java.Rvalue> timestampFunctionParam = new
ArrayList<>(Arrays.asList(atoms));
+ timestampFunctionParam.add(
+ new Java.AmbiguousName(Location.NOWHERE, new String[]
{DEFAULT_TIME_ZONE}));
+ return new Java.MethodInvocation(
+ Location.NOWHERE,
+ null,
+ "castToTimestamp",
+ timestampFunctionParam.toArray(new Java.Rvalue[0]));
Review Comment:
I tried to use it but I'm hesitated as many lib used it and we may need to
deal dependency shade issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
