yuxiqian commented on code in PR #3455:
URL: https://github.com/apache/flink-cdc/pull/3455#discussion_r1708376615
##########
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerITCase.java:
##########
@@ -399,8 +399,8 @@ void testTransformTwice(ValuesDataSink.SinkApi sinkApi)
throws Exception {
"AddColumnEvent{tableId=default_namespace.default_schema.table1,
addedColumns=[ColumnWithPosition{column=`col3` STRING, position=LAST,
existedColumnName=null}]}",
"RenameColumnEvent{tableId=default_namespace.default_schema.table1,
nameMapping={col2=newCol2, col3=newCol3}}",
"DropColumnEvent{tableId=default_namespace.default_schema.table1,
droppedColumnNames=[newCol2]}",
-
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[1, 1,
11], after=[], op=DELETE, meta=()}",
-
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[2, ,
22], after=[2, x, 22], op=UPDATE, meta=()}");
+
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[1,
11, 1], after=[], op=DELETE, meta=()}",
+
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[2,
22, ], after=[2, 22, x], op=UPDATE, meta=()}");
Review Comment:
Is transform semantic changed here? Seems after the schema evolution,
upstream schema will be `[col1, newCol3]`, and downstream schema should be
inferred as `[col1, newCol3, col12]` instead of `[col1, col12, newCol3]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
