aiwenmo commented on code in PR #3455:
URL: https://github.com/apache/flink-cdc/pull/3455#discussion_r1708810777
##########
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerITCase.java:
##########
@@ -399,8 +399,8 @@ void testTransformTwice(ValuesDataSink.SinkApi sinkApi)
throws Exception {
"AddColumnEvent{tableId=default_namespace.default_schema.table1,
addedColumns=[ColumnWithPosition{column=`col3` STRING, position=LAST,
existedColumnName=null}]}",
"RenameColumnEvent{tableId=default_namespace.default_schema.table1,
nameMapping={col2=newCol2, col3=newCol3}}",
"DropColumnEvent{tableId=default_namespace.default_schema.table1,
droppedColumnNames=[newCol2]}",
-
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[1, 1,
11], after=[], op=DELETE, meta=()}",
-
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[2, ,
22], after=[2, x, 22], op=UPDATE, meta=()}");
+
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[1,
11, 1], after=[], op=DELETE, meta=()}",
+
"DataChangeEvent{tableId=default_namespace.default_schema.table1, before=[2,
22, ], after=[2, 22, x], op=UPDATE, meta=()}");
Review Comment:
Yes. Transform semantic has changed. The previous discussion resulted in the
current code architecture being unable to achieve the expected semantics.
Based on the following code, it may be possible to achieve.
https://github.com/apache/flink-cdc/pull/3285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
