lvyanquan commented on code in PR #3495: URL: https://github.com/apache/flink-cdc/pull/3495#discussion_r1711033655
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/pom.xml: ########## @@ -0,0 +1,241 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-pipeline-connectors</artifactId> + <version>${revision}</version> + </parent> + + <artifactId>flink-cdc-pipeline-connector-elasticsearch</artifactId> + <packaging>jar</packaging> + + <name>flink-cdc-pipeline-connector-elasticsearch</name> + <url>http://maven.apache.org</url> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <elasticsearch.version>8.12.1</elasticsearch.version> + <flink.version>1.18.0</flink.version> + <scala.binary.version>4.0</scala.binary.version> + <jackson.version>2.13.2</jackson.version> + <surefire.module.config>--add-opens=java.base/java.util=ALL-UNNAMED</surefire.module.config> + <testcontainers.version>1.16.0</testcontainers.version> + <httpclient.version>4.5.13</httpclient.version> + <junit.jupiter.version>5.7.1</junit.jupiter.version> + <assertj.version>3.18.1</assertj.version> + <junit.version>4.13.2</junit.version> + <slf4j.version>1.7.32</slf4j.version> + <junit.platform.version>1.10.2</junit.platform.version> + <paimon.version>0.7.0-incubating</paimon.version> + <hadoop.version>2.8.5</hadoop.version> Review Comment: Unrelated version can be removed. ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/main/java/org/apache/flink/cdc/connectors/elasticsearch/config/ElasticsearchSinkOptions.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.elasticsearch.config; + +import org.apache.flink.cdc.connectors.elasticsearch.v2.NetworkConfig; + +import org.apache.http.HttpHost; + +import java.io.Serializable; +import java.util.List; + +/** Elasticsearch DataSink Options reference {@link ElasticsearchSinkOptions}. */ +public class ElasticsearchSinkOptions implements Serializable { + + private final int maxBatchSize; + private final int maxInFlightRequests; + private final int maxBufferedRequests; + private final long maxBatchSizeInBytes; + private final long maxTimeInBufferMS; + private final long maxRecordSizeInBytes; + private final NetworkConfig networkConfig; + private final int version; // 新增字段 Review Comment: Avoid using Chinese language in comments. ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-elasticsearch/src/main/java/org/apache/flink/cdc/connectors/elasticsearch/serializer/ColumnType.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.elasticsearch.serializer; + +/** + * Enumeration of column types supported in the Elasticsearch connector. These types represent the + * various data types that can be used in database columns and are relevant for serialization and + * deserialization processes. + */ +public enum ColumnType { Review Comment: This class is now useless and can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
