yuxiqian commented on PR #3495:
URL: https://github.com/apache/flink-cdc/pull/3495#issuecomment-2282976584
Hi @proletarians,
Seems license check failed since it detects questionable licenses, which
isn't strictly forbidden to use but requires manual verify and confirmation.
By quickly checking licenses used by `jakarta.json/jakarta.json-api` and
`org.eclipse.parsson/parsson` I believe they could be legally packaged into CDC
binary release.
You may apply the folllowing patch to suppress the false alarm:
```diff
--- a/tools/ci/license_check.rb (revision
44ea2a73d662b6adaae1c79beb3f1ab3e37c6278)
+++ b/tools/ci/license_check.rb (date 1723425566467)
@@ -75,6 +75,9 @@
'org.glassfish.jersey', # dual-licensed under GPL 2 and EPL 2.0
'org.glassfish.hk2', # dual-licensed under GPL 2 and EPL 2.0
'javax.ws.rs-api', # dual-licensed under GPL 2 and EPL 2.0
+ 'jakarta.json-api', # dual-licensed under GPL 2 and EPL 2.0
+ 'org.eclipse.parsson', # EPL 2.0
+ 'org/eclipse/parsson', # EPL 2.0
'jakarta.ws.rs' # dual-licensed under GPL 2 and EPL 2.0
].freeze
@@ -110,7 +113,7 @@
Zip::File.open(jar_file) do |jar|
jar.filter { |e| e.ftype == :file }
.filter { |e|
!File.basename(e.name).downcase.end_with?(*BINARY_FILE_EXTENSIONS) }
- .filter { |e| !File.basename(e.name).downcase.start_with? 'license',
'dependencies' }
+ .filter { |e| !File.basename(e.name).downcase.start_with? 'license',
'dependencies', 'notice' }
.filter { |e| EXCEPTION_PACKAGES.none? { |ex| e.name.include? ex } }
.map do |e|
content = e.get_input_stream.read.force_encoding('UTF-8')
```
[1] https://www.apache.org/legal/resolved.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
