twalthr commented on code in PR #25186:
URL: https://github.com/apache/flink/pull/25186#discussion_r1711553638
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -80,17 +80,25 @@ protected void setup() throws Exception {
@Test
void testCompilePlanSql() throws IOException {
CompiledPlan compiledPlan =
- tableEnv.compilePlanSql("INSERT INTO MySink SELECT * FROM
MyTable");
+ tableEnv.compilePlanSql(
+ "INSERT INTO MySink SELECT * FROM MyTable"
+ // OPTIONS hints here do not play any
significant role
+ // we just have to be sure that these options
are present in compile
+ // plan
+ + "/*+ OPTIONS('bounded'='true',
'sca.parallelism'='2') */");
Review Comment:
```suggestion
+ "/*+ OPTIONS('bounded'='true',
'scan.parallelism'='2') */");
```
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -80,17 +80,25 @@ protected void setup() throws Exception {
@Test
void testCompilePlanSql() throws IOException {
CompiledPlan compiledPlan =
- tableEnv.compilePlanSql("INSERT INTO MySink SELECT * FROM
MyTable");
+ tableEnv.compilePlanSql(
Review Comment:
Don't modify an existing test but add a new one like
`testSourceTableWithHints()`
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/internal/StatementSetImplTest.java:
##########
@@ -65,15 +65,19 @@ void testGetJsonPlan() throws IOException {
tableEnv.executeSql(sinkTableDdl);
StatementSet stmtSet = tableEnv.createStatementSet();
- stmtSet.addInsertSql("INSERT INTO MySink SELECT * FROM MyTable");
+ stmtSet.addInsertSql(
Review Comment:
This test is not required. We can drop it.
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/schema/CatalogSourceTable.java:
##########
@@ -119,7 +119,7 @@ public RelNode toRel(ToRelContext toRelContext) {
!schemaTable.isStreamingMode(),
context.getTableConfig(),
relBuilder,
- schemaTable.getContextResolvedTable(),
+ catalogTable,
Review Comment:
rename the variable to `contextTableWithHints`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
