snuyanzin commented on code in PR #25186:
URL: https://github.com/apache/flink/pull/25186#discussion_r1712058342
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -83,14 +83,25 @@ void testCompilePlanSql() throws IOException {
tableEnv.compilePlanSql("INSERT INTO MySink SELECT * FROM
MyTable");
String expected =
TableTestUtil.readFromResource("/jsonplan/testGetJsonPlan.out");
assertThat(
- TableTestUtil.replaceExecNodeId(
- TableTestUtil.replaceFlinkVersion(
- TableTestUtil.getFormattedJson(
- compiledPlan.asJsonString()))))
+ getPreparedToCompareCompilePlan(
+
TableTestUtil.getFormattedJson(compiledPlan.asJsonString())))
.isEqualTo(
- TableTestUtil.replaceExecNodeId(
- TableTestUtil.replaceFlinkVersion(
-
TableTestUtil.getFormattedJson(expected))));
+
getPreparedToCompareCompilePlan(TableTestUtil.getFormattedJson(expected)));
Review Comment:
ideally here should be just expected however because of difference between
`compiledPlan.asJsonString` and `expected` it is like it is
room for improvement within another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
