[
https://issues.apache.org/jira/browse/FLINK-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715166#comment-15715166
]
ASF GitHub Bot commented on FLINK-5163:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2871#discussion_r90643076
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -104,21 +114,63 @@ public ContinuousFileMonitoringFunction(
);
this.format = Preconditions.checkNotNull(format, "Unspecified
File Input Format.");
- this.path = Preconditions.checkNotNull(path, "Unspecified
Path.");
+ this.path =
Preconditions.checkNotNull(format.getFilePath().toString(), "Unspecified
Path.");
this.interval = interval;
this.watchType = watchType;
this.readerParallelism = Math.max(readerParallelism, 1);
this.globalModificationTime = Long.MIN_VALUE;
}
+ public long getGlobalModificationTime() {
--- End diff --
This should probably have `@VisibleForTesting`.
> Make the production functions rescalable (apart from the Rolling/Bucketing
> Sinks)
> ---------------------------------------------------------------------------------
>
> Key: FLINK-5163
> URL: https://issues.apache.org/jira/browse/FLINK-5163
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> This issue targets porting all the functions in the production code to the
> new state abstractions. These functions are:
> 1) StatefulSequenceSource
> 2) MessageAcknowledgingSourceBase
> 3) FromElementsFunction
> 4) ContinuousFileMonitoringFunction
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
