[ 
https://issues.apache.org/jira/browse/FLINK-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715161#comment-15715161
 ] 

ASF GitHub Bot commented on FLINK-5163:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2871#discussion_r90641362
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java
 ---
    @@ -73,27 +76,31 @@
      *     }
      * }
      * }</pre>
    - * 
    + *
    + * <b>NOTE:</b> This source has a parallelism of {@code 1}.
    + *
      * @param <Type> The type of the messages created by the source.
      * @param <UId> The type of unique IDs which may be used to acknowledge 
elements.
      */
     @PublicEvolving
     public abstract class MessageAcknowledgingSourceBase<Type, UId>
        extends RichSourceFunction<Type>
    -   implements Checkpointed<SerializedCheckpointData[]>, CheckpointListener 
{
    +   implements CheckpointedFunction, CheckpointListener {
     
        private static final long serialVersionUID = -8689291992192955579L;
     
        private static final Logger LOG = 
LoggerFactory.getLogger(MessageAcknowledgingSourceBase.class);
     
    +   private static final String MESSAGE_ACKNOWLEDGING_SOURCE_STATE = 
"message-acknowledging-source-state";
    --- End diff --
    
    See comments on the other functions, I'm not writing it again ... 😉 


> Make the production functions rescalable (apart from the Rolling/Bucketing 
> Sinks)
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-5163
>                 URL: https://issues.apache.org/jira/browse/FLINK-5163
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.2.0
>
>
> This issue targets porting all the functions in the production code to the 
> new state abstractions. These functions are:
> 1) StatefulSequenceSource
> 2) MessageAcknowledgingSourceBase
> 3) FromElementsFunction
> 4) ContinuousFileMonitoringFunction



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to