sn-12-3 commented on PR #23563: URL: https://github.com/apache/flink/pull/23563#issuecomment-2301998434
@injae-kim , I was looking at the change, this line in [here](https://github.com/apache/flink/blob/bf63127aaa34a5863bccfe0e019b8d6036c7f9c0/flink-core/src/main/java/org/apache/flink/core/memory/DataOutputSerializer.java#L110) is increasing the position by 1 to write each character of string into a byte. But this line in [here](https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/core/memory/DataOutputSerializer.java#L163) is to safely move the position pointer forward by the length of the data being written isn't it, advancing to a safe position so that it won't interfere with other functions. I believe the same has been done for other methods as well in the flink-core/src/main/java/org/apache/flink/core/memory/DataOutputSerializer.java cc @all-cloudz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
