all-cloudz commented on PR #23563:
URL: https://github.com/apache/flink/pull/23563#issuecomment-2308142995
I added code to move the position in the same way as the existing
DataOutputSerializer code and ran the test. The following error occurred, which
was due to moving the position multiple times. So, I believe the changes I made
are correct.
```test
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
0.040 s <<< FAILURE! -- in
org.apache.flink.core.memory.DataInputOutputSerializerTest
[ERROR]
org.apache.flink.core.memory.DataInputOutputSerializerTest.testWriteBytes --
Time elapsed: 0.032 s <<< ERROR!
java.lang.IllegalArgumentException: newLimit > capacity: (26 > 14)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:395)
at java.base/java.nio.Buffer.limit(Buffer.java:369)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529)
at
org.apache.flink.core.memory.DataOutputSerializer.wrapAsByteBuffer(DataOutputSerializer.java:52)
at
org.apache.flink.core.memory.DataInputOutputSerializerTest.testWriteBytes(DataInputOutputSerializerTest.java:152)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at
java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at
java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
```
While running this test, I noticed that the test code format does not adhere
to the guidelines. I will correct it and commit the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
