Zakelly commented on code in PR #25257:
URL: https://github.com/apache/flink/pull/25257#discussion_r1740624245
##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java:
##########
@@ -493,12 +490,14 @@ public static class RocksdbCompactFilterCleanupStrategy
implements CleanupStrategies.CleanupStrategy {
private static final long serialVersionUID = 3109278796506988980L;
+ @Deprecated
/**
* Default value is 30 days so that every file goes through the
compaction process at least
* once every 30 days if not compacted sooner.
*/
static final Duration DEFAULT_PERIODIC_COMPACTION_TIME =
Duration.ofDays(30);
Review Comment:
```suggestion
* @deprecated Use {@code
*
RocksDBConfigurableOptions#COMPACT_FILTER_PERIODIC_COMPACTION_TIME} instead.
*/
@Deprecated static final Duration DEFAULT_PERIODIC_COMPACTION_TIME =
Duration.ofDays(30);
```
##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java:
##########
@@ -493,12 +490,14 @@ public static class RocksdbCompactFilterCleanupStrategy
implements CleanupStrategies.CleanupStrategy {
private static final long serialVersionUID = 3109278796506988980L;
+ @Deprecated
/**
* Default value is 30 days so that every file goes through the
compaction process at least
* once every 30 days if not compacted sooner.
*/
static final Duration DEFAULT_PERIODIC_COMPACTION_TIME =
Duration.ofDays(30);
+ @Deprecated
Review Comment:
```suggestion
/**
* @deprecated Use {@code
*
RocksDBConfigurableOptions#COMPACT_FILTER_QUERY_TIME_AFTER_NUM_ENTRIES} instead.
*/
@Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
