Zakelly commented on code in PR #25257:
URL: https://github.com/apache/flink/pull/25257#discussion_r1741603744
##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java:
##########
@@ -499,6 +496,12 @@ public static class RocksdbCompactFilterCleanupStrategy
*/
static final Duration DEFAULT_PERIODIC_COMPACTION_TIME =
Duration.ofDays(30);
Review Comment:
We should mark this `@Deprecated`
##########
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java:
##########
@@ -499,6 +496,12 @@ public static class RocksdbCompactFilterCleanupStrategy
*/
static final Duration DEFAULT_PERIODIC_COMPACTION_TIME =
Duration.ofDays(30);
+ @Deprecated
Review Comment:
Well, it's better to put `@Deprecated` below the java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
