hlteoh37 commented on code in PR #151:
URL:
https://github.com/apache/flink-connector-aws/pull/151#discussion_r1741899825
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java:
##########
@@ -168,8 +194,15 @@ private String getShardIterator(
try {
return
dynamoDbStreamsClient.getShardIterator(requestBuilder.build()).shardIterator();
} catch (ResourceNotFoundException e) {
- LOG.info(
- "Received ResourceNotFoundException. "
+ LOG.warn(
+ "Received ResourceNotFoundException from GetShardIterator.
"
+ + "Shard {} of stream {} is no longer valid,
marking it as complete.",
Review Comment:
this is good to be warn. Good call.
Let's add a warning here too that this might indicate data loss (since shard
was not fully read, but it already expired)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
