zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751623399


##########
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/TimeWindowTranslationTest.scala:
##########
@@ -68,13 +66,13 @@ class TimeWindowTranslationTest extends 
AbstractTestBaseJUnit4 {
 
     val window2 = source
       .keyBy(0)
-      .timeWindow(Time.minutes(1))
-      .apply(new WindowFunction[(String, Int), (String, Int), Tuple, 
TimeWindow]() {
-        def apply(
-            key: Tuple,
+      .windowAll(TumblingProcessingTimeWindows

Review Comment:
   same concern as elsewhere about windowAll on a keyed stream



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to