hlteoh37 commented on code in PR #166:
URL:
https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762594562
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java:
##########
@@ -104,6 +104,11 @@ public DynamoDbStreamsSourceEnumerator(
public void start() {
context.callAsync(this::discoverSplits, this::processDiscoveredSplits);
final long shardDiscoveryInterval =
sourceConfig.get(SHARD_DISCOVERY_INTERVAL).toMillis();
+ context.callAsync(
+ this::incrementallyDiscoverSplits,
+ this::processDiscoveredSplits,
+ 0,
+ shardDiscoveryInterval);
Review Comment:
should we separate out the configuration for incremental shard discovery
interval and the full shard discovery interval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
