hlteoh37 commented on code in PR #166:
URL:
https://github.com/apache/flink-connector-aws/pull/166#discussion_r1762608231
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/tracker/SplitTracker.java:
##########
@@ -185,7 +186,8 @@ public List<DynamoDbStreamsShardSplit>
getUnassignedChildSplits(Set<String> pare
if (!parentChildSplitMap.containsKey(splitId)) {
LOG.warn(
"splitId: {} is not present in
parent-child relationship map. "
- + "This indicates that there
might be some data loss in the application",
+ + "This indicates that either
there might be some data loss in the "
+ + "application or the child
shard hasn't been discovered yet",
Review Comment:
Do we see this very often? If so, this is worrying, and we should create a
JIRA to track an improvement. We know our setup is resilient against this,
because the child will get picked up eventually, but it would be good to not
worry people unnecessarily!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
