xintongsong commented on code in PR #25226:
URL: https://github.com/apache/flink/pull/25226#discussion_r1764322519
##########
flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java:
##########
@@ -665,6 +666,16 @@ public RecoverableWriter createRecoverableWriter() throws
IOException {
return IFileSystem.super.createRecoverableWriter();
}
+ @PublicEvolving
+ @Override
+ public RecoverableWriter createRecoverableWriter(boolean noLocalWrite)
throws IOException {
Review Comment:
I'd suggest to add a method `createRecoverbleWriter(Map<String, String>
conf)`, and introduce some String constants for the config keys. This helps
avoid introducing a new overloading `createRecoverableWriter(x, y, ...)` every
time we need a new parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
