xintongsong commented on code in PR #25226:
URL: https://github.com/apache/flink/pull/25226#discussion_r1764328992
##########
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopRecoverableWriter.java:
##########
@@ -46,13 +46,22 @@ public class HadoopRecoverableWriter implements
RecoverableWriter {
/** The Hadoop file system on which the writer operates. */
protected final org.apache.hadoop.fs.FileSystem fs;
+ protected final boolean noLocalWrite;
Review Comment:
It seems the only reason this field is `protected` rather than `private` is
that it is used in a test case. This usually indicates a white-box test, which
should be avoided as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
