davidradl commented on code in PR #204:
URL: https://github.com/apache/flink-docker/pull/204#discussion_r1773514085
##########
add-version.sh:
##########
@@ -53,7 +53,7 @@ if [ -z "$flink_release" ] || [ -z "$flink_version" ]; then
exit 1
fi
-if [[ ! "$flink_version" =~ ^$flink_release\.+ ]]; then
+if [[ "$flink_version" != "$flink_release"* ]]; then
Review Comment:
the way it is written, this will accept 1.2 as both the Flink version and
release, but the example in the above comments is
```
flink_release= # Like 1.2
flink_version= # Like 1.2.0
```
implies that the version is always longer than the release. This looks
inconsistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
