xintongsong commented on code in PR #204:
URL: https://github.com/apache/flink-docker/pull/204#discussion_r1774370440
##########
add-version.sh:
##########
@@ -53,7 +53,7 @@ if [ -z "$flink_release" ] || [ -z "$flink_version" ]; then
exit 1
fi
-if [[ ! "$flink_version" =~ ^$flink_release\.+ ]]; then
+if [[ "$flink_version" != "$flink_release"* ]]; then
Review Comment:
We are preparing for a 2.0-preview release, where:
```
flink_release="2.0"
flink_version="2.0-preview1"
```
This is currently rejected by the current check.
Moreover, these scripts are mainly used for creating docker images for Flink
releases. The release managers know what version names to expect, and are not
highly relying on these checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
