Zakelly commented on code in PR #25125:
URL: https://github.com/apache/flink/pull/25125#discussion_r1778555116
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java:
##########
@@ -111,6 +111,6 @@ public enum StateRequestType {
/** Get value from aggregating state by {@link
AggregatingState#asyncGet()}. */
AGGREGATING_GET,
- /** Add element to aggregating state by {@link
AggregatingState#asyncAdd(Object)}. */
- AGGREGATING_ADD
+ /** Put element to aggregating state by {@link
AggregatingState#asyncAdd(Object)}. */
+ AGGREGATING_PUT
Review Comment:
But I'd suggest the original name, as from user's perspective he is 'adding'
more to his state and get a aggregated result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
