jectpro7 commented on code in PR #25125:
URL: https://github.com/apache/flink/pull/25125#discussion_r1779366932
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java:
##########
@@ -111,6 +111,6 @@ public enum StateRequestType {
/** Get value from aggregating state by {@link
AggregatingState#asyncGet()}. */
AGGREGATING_GET,
- /** Add element to aggregating state by {@link
AggregatingState#asyncAdd(Object)}. */
- AGGREGATING_ADD
+ /** Put element to aggregating state by {@link
AggregatingState#asyncAdd(Object)}. */
+ AGGREGATING_PUT
Review Comment:
@Zakelly , in terms of user experience, it is better to use ADD. But in my
opinion, it should transparent to user, the user only use the API we expose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
