[
https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887987#comment-17887987
]
Arvid Heise commented on FLINK-36455:
-------------------------------------
I'm not an expert of the SFS but from cross checking the code, it looks safe
because it has no retries whatsoever. So it would fail on transient error and
trigger a new final checkpoint which is in accordance with the contract of
notifyCheckpointCompleted.
> Sink should commit everything on notifyCheckpointCompleted
> ----------------------------------------------------------
>
> Key: FLINK-36455
> URL: https://issues.apache.org/jira/browse/FLINK-36455
> Project: Flink
> Issue Type: Bug
> Components: API / Core
> Reporter: Arvid Heise
> Assignee: Arvid Heise
> Priority: Major
> Fix For: 2.0-preview
>
>
> Currently, we retry committables at some time later until they eventually
> succeed.
> However, that violates the contract of notifyCheckpointCompleted which states
> that all side effect must be committed before returning the method. In
> particular, notifyCheckpointCompleted must fail if we cannot guarantee that
> all side effects are committed for final checkpoints. As soon as
> notifyCheckpointCompleted returns, the final checkpoint is deemed completed,
> which currently may mean that some transactions are still open.
> The solution is that all retries must happen in a close loop in
> notifyCheckpointCompleted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
