[
https://issues.apache.org/jira/browse/FLINK-36455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895909#comment-17895909
]
Arvid Heise commented on FLINK-36455:
-------------------------------------
Merged
bc0f241b86799a39d7ce08e5902e47c71bdaf68f..13fe0e641cdd3260fd52c1e7a15a8d595bb29624
into main.
> Sink should commit everything on notifyCheckpointCompleted
> ----------------------------------------------------------
>
> Key: FLINK-36455
> URL: https://issues.apache.org/jira/browse/FLINK-36455
> Project: Flink
> Issue Type: Bug
> Components: API / Core
> Reporter: Arvid Heise
> Assignee: Arvid Heise
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.0.0
>
>
> Currently, we retry committables at some time later until they eventually
> succeed.
> However, that violates the contract of notifyCheckpointCompleted which states
> that all side effect must be committed before returning the method. In
> particular, notifyCheckpointCompleted must fail if we cannot guarantee that
> all side effects are committed for final checkpoints. As soon as
> notifyCheckpointCompleted returns, the final checkpoint is deemed completed,
> which currently may mean that some transactions are still open.
> The solution is that all retries must happen in a close loop in
> notifyCheckpointCompleted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
