RocMarshal commented on code in PR #25174:
URL: https://github.com/apache/flink/pull/25174#discussion_r1797643272
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/PhysicalSlotProviderImpl.java:
##########
@@ -59,12 +59,7 @@ public void disableBatchSlotRequestTimeoutCheck() {
public Map<SlotRequestId, CompletableFuture<PhysicalSlotRequest.Result>>
allocatePhysicalSlots(
Review Comment:
@1996fanrui Sounds great~
I tried to make some analyzing about it.
From the existing structure, it seems more appropriate to merge
`PhysicalSlotProvider` and `SlotPool` together?
In my limited read, there seem to be a few of other issues as the red-lines.
Could you help give some related ideas about it ? Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
