RocMarshal commented on code in PR #25174:
URL: https://github.com/apache/flink/pull/25174#discussion_r1798242400
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/SlotInfo.java:
##########
@@ -54,10 +59,27 @@ public interface SlotInfo {
*/
ResourceProfile getResourceProfile();
+ /**
+ * Set the loading.
+ *
+ * @param loadingWeight loading weight to set.
+ */
+ void setLoading(LoadingWeight loadingWeight);
+
+ /** Reset the loading. */
+ void resetLoading();
+
Review Comment:
It's used in the block
(org.apache.flink.runtime.jobmaster.slotpool.PendingRequest) by `PhysicalSlot`
```
boolean fulfill(PhysicalSlot slot) {
Preconditions.checkState(
slot.getLoading().equals(getLoading()),
"Unexpected loading weight, it may be a bug.");
return slotFuture.complete(slot);
}
```
So, what about move the method declaration into `PhysicalSlot` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
