ferenc-csaky commented on code in PR #25494:
URL: https://github.com/apache/flink/pull/25494#discussion_r1802374362
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -94,8 +94,8 @@ under the License.
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- <version>3.10.6.Final</version>
+ <artifactId>netty-all</artifactId>
Review Comment:
I believe we should not depend on Netty directly here. Netty 4 comes through
`flink-shaded`, Netty 3 was only listed here directly because this specific
module required it, but since that won't be the case anymore, I think we can
simply remove the direct Netty dep and the relocation, as the module already
inludes `flink-shaded-netty`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
