gracegrimwood commented on code in PR #25494:
URL: https://github.com/apache/flink/pull/25494#discussion_r1804047289
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -94,8 +94,8 @@ under the License.
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- <version>3.10.6.Final</version>
+ <artifactId>netty-all</artifactId>
Review Comment:
Unfortunately we do still need to have Netty directly declared in the
dependencies. If the `io.netty:netty-all` dependency is missing from the POM,
Pekko throws at runtime with
`java.lang.IllegalStateException: Classic remoting is enabled but Netty is
not on the classpath, it must be added explicitly. See
https://pekko.apache.org/docs/pekko/current/remoting.html`. Those [Pekko
docs](https://pekko.apache.org/docs/pekko/current/remoting.html) linked in the
error message insist that it must be declared explicitly:
> Classic remoting depends on Netty. This needs to be explicitly added as a
dependency so that users not using classic remoting do not have to have Netty
on the classpath
The relocation is there so that we can use the `flink-shaded-netty` version
for Pekko rather than having two seperate copies of Netty 4, it is not strictly
necessary and there might be a better or nicer way to do it. But as far as I
can tell there is no way to get around needing a direct Netty dependency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
